Document testing use of @pytest.mark.disable_db
#4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not completely obvious that the database is enabled by default and tests that don't require it should declare that. Document this so test authors are more likely to be aware.
mikerkelly
force-pushed
the
mikerkelly/docs/disable-db-decorator
branch
from
0d57cf7
to
421fe3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not completely obvious that the database is enabled by default and tests that don't require it should declare that. Document this so test authors are more likely to be aware.
For an example of where I didn't get this right initially, see #4717 / f12a356.